Wip level and stacktrace output #4
Conversation
We'll rely on the timbre/stacktrace Fn to do this -- so the output should more or less match what's seen in the default :println appender.
.. so things sort of match the default :println appender in Timbre.
| @@ -1,5 +1,6 @@ | |||
| (ns clj-journal.timbre | |||
| (:require [clj-journal.log :refer [jsend]])) | |||
| (:require [clojure.string :as str] | |||
There was a problem hiding this comment.
Whops, I think the :as str part could be removed.
|
Thank you for your PR @lnostdal! I think I actually made a conscious decision to not have the log level be part of the message as journald already have that information, but I think it'd be a good idea to have the option to more easily customize the format, e.g. to prefix the error level like you've done. Since you're the first active user I know of outside of my day job I'd be really glad to hear your thoughts; what would make this library better/easier/more flexible? |
|
Yup, the meta-data always contains the level. I suppose the :output-fn needs to be flexible then; could do a (merge .. ..) somewhere perhaps so users can override this; it might already be possible. [ need to look into this a bit later .. :) ] |
Only briefly tested, but perhaps useful.
(log/error (Exception. "hi"))will yield a stacktrace just like the standard timbre appender.