Add new protocol and native support for Ordering #591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while looking over https://github.com/khvzak/script-bench-rs/blob/main/benches/rune.rs that the comparison operations were implemented using associated functions, which is not very idiomatic.
This introduces the
CMP
protocol, which matchesOrd::cmp
in Rust, allowing you to implement a single handler for all total comparison operators.At some point down the line we might want to look into supporting
PARTIAL_CMP
as well.The second commit refines testing, and fixes support for tuple index assign operations.