Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support implementing protocols through #[rune::function] #584

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Support implementing protocols through #[rune::function] #584

merged 3 commits into from
Jul 21, 2023

Conversation

ModProg
Copy link
Contributor

@ModProg ModProg commented Jul 19, 2023

No description provided.

@udoprog udoprog self-requested a review July 19, 2023 14:18
udoprog
udoprog reviewed Jul 20, 2023
View reviewed changes
crates/rune-macros/src/function.rs Outdated Show resolved Hide resolved
crates/rune-macros/src/function.rs Outdated Show resolved Hide resolved
@udoprog
Copy link
Collaborator

udoprog commented Jul 20, 2023

Thanks! Please also do add some documentation and tests.

@udoprog udoprog added the enhancement New feature or request label Jul 20, 2023
@udoprog udoprog changed the title support Protocol with function macro Support implementing protocols through #[rune::function] Jul 20, 2023
@ModProg ModProg force-pushed the function-macro-protocol branch from be4509d to d781d51 Compare July 20, 2023 14:31
@udoprog
Copy link
Collaborator

udoprog commented Jul 21, 2023

Thank you!

@udoprog udoprog merged commit ad08e89 into rune-rs:main Jul 21, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udoprog udoprog udoprog left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ModProg @udoprog