Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix languageserver for neovim by not borrowing method in IncomingMessage #520

Merged
merged 2 commits into from
May 23, 2023

Conversation

ModProg
Copy link
Contributor

@ModProg ModProg commented May 22, 2023

  • add Context::iter_functions to languageserver feature
  • fix languageserver for neovim by not borrowing method in IncomingMessage

@ModProg ModProg changed the title fix lsp fix languageserver for neovim by not borrowing method in IncomingMessage May 22, 2023
@udoprog
Copy link
Collaborator

udoprog commented May 23, 2023

Huh, which method is being used? I thought all of them could be decoded verbatim 😄

@ModProg
Copy link
Contributor Author

ModProg commented May 23, 2023

Huh, which method is being used? I thought all of them could be decoded verbatim smile

I guess they should be, but it sends the open event as textDocument\/didOpen which is apparently valid json.

@ModProg
Copy link
Contributor Author

ModProg commented May 23, 2023

probably whatever json library they use is a bit eager to escape.

@udoprog udoprog merged commit c994be9 into rune-rs:main May 23, 2023
@udoprog udoprog changed the title fix languageserver for neovim by not borrowing method in IncomingMessage Fix languageserver for neovim by not borrowing method in IncomingMessage May 23, 2023
@udoprog
Copy link
Collaborator

udoprog commented May 23, 2023

All right, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants