Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server changes #482

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Language server changes #482

merged 3 commits into from
Apr 6, 2023

Conversation

udoprog
Copy link
Collaborator

@udoprog udoprog commented Apr 6, 2023

This pull request significantly improves handling of multiple sources in the language server and adds workspace support.

Emitting diagnostics have been reworked, so that it should be less likely to get stuck in a state where diagnostics is never removed.

Workspace support has also been added in the language server. A workspace is triggered if a Rune.toml file is found at the root of the workspace. The sources associated with a workspace are always collected and processed by the language server.

On top of this, any sources you open up will be handled as normal entrypoints unless they are part of a workspace.

This means we can finally deal with non-trivial project topologies and most improtant modules. With the caveat that these must have an associated Rune.toml file which points out the entrypoint.

Workspace configuration also comes with its own diagnostics:

image

Hovering over the rune-languageserver bottom left option reveals a few controls:

image

Stopping the server prevents it from running at all (during this session) in case there are any issues.

@udoprog udoprog added the enhancement New feature or request label Apr 6, 2023
@udoprog
Copy link
Collaborator Author

udoprog commented Apr 6, 2023

This is all part of rune-vscode 0.12.7 for anyone who wants to take it for a spin. It should automatically download the latest nightly languageserver which comes with all the listed improvements.

@udoprog udoprog merged commit 710017e into main Apr 6, 2023
@udoprog udoprog deleted the language-server-changes branch April 6, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant