Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config storage tree errors using file provider #3962

Merged
merged 3 commits into from
Aug 30, 2018
Merged

Fix config storage tree errors using file provider #3962

merged 3 commits into from
Aug 30, 2018

Conversation

gschueler
Copy link
Member

Is this a bugfix, or an enhancement? Please describe.

Fix #3960

Describe the solution you've implemented

  • Check hasDirectory before calling listDirectory, for both config service and project config
  • handle case where project config does not exist when saving new config

Additional context

Only occurs when using file provider for config storage backend.

@gschueler gschueler merged commit 8e45783 into master Aug 30, 2018
@gschueler gschueler added this to the 3.0.6 milestone Aug 30, 2018
@gschueler gschueler deleted the issue/3960-config-storage-tree-errors branch August 30, 2018 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.6
Development

Successfully merging this pull request may close these issues.

Using file storage for config storage tree causes some problems
1 participant
@gschueler