Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users summary page #3906

Merged
merged 4 commits into from
Aug 30, 2018
Merged

Users summary page #3906

merged 4 commits into from
Aug 30, 2018

Conversation

jtobard
Copy link
Contributor

@jtobard jtobard commented Aug 24, 2018

New Page listed in the System menu only to users with admin privileges:

System menu

This page list the users (in the table rduser) and some info about them:

  • Login username
  • Profile information (first name, last name, email)
  • Creation and modification date
  • Last time the user runs a job
  • Number of tokens

Page

@@ -63,5 +63,12 @@
<g:message code="gui.menu.PasswordUtility"/>
</g:link>
</li>
<g:if test="${authRead}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this auth check does not seem correct, if the summary action requires user:admin access.

@@ -3033,5 +3033,33 @@ class MenuController extends ControllerBase implements ApplicationContextAware{
}
return redirect(controller:'menu',action:'jobs', params: [project: params.project])
}

def summary(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should change the action name to be userSummary or something clearer

@gschueler gschueler modified the milestones: 3.0.4, 3.0.5 Aug 25, 2018
@jtobard
Copy link
Contributor Author

jtobard commented Aug 28, 2018

Add the summary to /user/list endpoint if the api_version is >= 27, documentation PR: rundeck/docs#104

@gschueler gschueler modified the milestones: 3.0.5, 3.0.6 Aug 28, 2018
@gschueler
Copy link
Member

@jtobard maybe try rebasing on current master

@jtobard jtobard force-pushed the dev/user-list-menu branch from 5a926ce to d7adbe3 Compare August 30, 2018 14:05
@gschueler gschueler merged commit f120d33 into master Aug 30, 2018
@gschueler gschueler deleted the dev/user-list-menu branch August 30, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants