Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix args option parsing #367

Merged

Conversation

gschueler
Copy link
Member

Fix for original issue #201 described here:

Using a simple bash script as follows:

#!/bin/bash
echo "Here's the list of command line options:"

for i in "$@"; do
  echo "** $i **"
done

I have defined an option (named "option1") with no default value and no restrictions, so the user can enter any value.
In the job definition, I invoke the command

/path/to/testprog.sh ${option.option1}

If the value entered by the user does not start with a dash, the program receives it correctly; if it starts with a dash, the programs receives the string "true". This looks like a pretty serious bug to me, unless I'm misunderstanding something (which of course is possible).

I'm also having trouble running the same job from the command line, I'll open a separate issue for that.

Remove old boolean value support for "-flag", and clean up
javadoc and parsing.
@ghost ghost assigned gschueler Apr 23, 2013
gschueler added a commit that referenced this pull request Apr 23, 2013
@gschueler gschueler merged commit 3434b35 into rundeck:development Apr 23, 2013
@gschueler gschueler deleted the feature/fix-args-option-parsing branch April 23, 2013 18:59
@buildhive
Copy link

DTO Labs » rundeck #48 SUCCESS
This pull request looks good
(what's this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants