Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scm cluster config #3102

Merged
merged 10 commits into from
Feb 5, 2018
Merged

Conversation

jtobard
Copy link
Contributor

@jtobard jtobard commented Jan 30, 2018

See #1622

Removed member unique config. Now, on cluster mode, the configuration its saved on the scm folder, not in the scm/nodeUuid folder. This require configure again the scm plugins on cluster environments.
If a job is imported or from one node, other nodes got the same information.

@jtobard jtobard added this to the 2.11.x milestone Jan 30, 2018
@@ -129,4 +129,7 @@ ScmExportResult export(
* @param originalPath original path
*/
ScmDiffResult getFileDiff(JobExportReference job, String originalPath);


Map clusterFixJobs(List<JobReference> jobs);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add javadoc to explain what this is for?

jobs.each { job ->
def storedCommitId = ((JobScmReference)job).scmImportMetadata?.commitId
def commitId = lastCommitForPath(getRelativePathForJob(job))
println(commitId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz :)

@gschueler gschueler merged commit eeab402 into rundeck:prerelease-2.11.0 Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants