Flag for success when node filter does not match any node #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschueler
requested changes
Apr 26, 2017
| @@ -67,6 +68,7 @@ public class BaseNodeFilters { | |||
| nodeIncludeOsVersion(nullable: true) | |||
| nodeExcludeOsVersion(nullable: true) | |||
| nodeExcludePrecedence(nullable: true) | |||
| //successOnEmptyNodeFilter(nullable: true) | |||
There was a problem hiding this comment.
this should be included nullable:true, otherwise database schema update will fail for existing job definitions
gschueler
approved these changes
Jun 20, 2017
|
Hi, Has this feature been implemented ? I hace checked "Dispatch to nodes" Many thanks for your help |
|
@jerome83136 the message has changed, now it looks like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1814
Add a flag to the job on create/edit for success and continue on a step without target.
This property is rendered only when
Dispatch to Nodesis selected and is false by default.Included in export/import job via xml/yaml using
successOnEmptyNodeFilter=true.Gui:
