Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents remote option spam in issue 1391 by using onChange event #1415

Merged
merged 4 commits into from
Feb 25, 2016

Conversation

rophy
Copy link
Contributor

@rophy rophy commented Aug 24, 2015

Issue #1391 describes 2 problems about remote URL option:

  1. Remote option triggered before all required deps are available
  2. Remote option (seems to be) repeatly triggered on every character typed, causing spam to the remote server. Ideally remote option should only be triggered after I switch to another field.

I tried to fix Problem 2 by using Event.observe(id, 'change', handler) instead of Form.Element.Observer(), as Form.Element.Observer() seems to get triggered on every character typed.

I'd like to fix Problem 1 as well, but looking through the js file, I couldn't find a simple way to determine if an option is "required" or not.

@rophy
Copy link
Contributor Author

rophy commented Sep 2, 2015

Fixed Problem 1 as well (by checking visibility of the reqwarning icon)

@gschueler gschueler added this to the 2.5.4 milestone Sep 2, 2015
@rophy rophy changed the title Prevents remote optoin spam in issue 1391 by using onChange event Prevents remote option spam in issue 1391 by using onChange event Sep 4, 2015
@gschueler gschueler modified the milestones: 2.6.2, 2.6.3 Dec 1, 2015
gschueler added a commit that referenced this pull request Feb 25, 2016
Prevents remote option spam in issue 1391 by using onChange event
@gschueler gschueler merged commit 90b5037 into rundeck:development Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants