Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rundeck 2.0.1 - Improve look of unauthorized access pages #675

Closed
mumblez opened this issue Feb 26, 2014 · 3 comments
Closed

Rundeck 2.0.1 - Improve look of unauthorized access pages #675

mumblez opened this issue Feb 26, 2014 · 3 comments
Labels
bug
Milestone
2.0.2

Comments

@mumblez
Copy link

mumblez commented Feb 26, 2014

When a user is part of a group that can only run specific jobs and is able to see activities of past jobs, if they click on a job they're not authorized to run they get a very sparse page e.g.

"Unauthorized
×
test.user is not authorized to: Read Job 1d425f58-524f-497a-b8e8-e39f8c59a01d:"

<html>
<head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
    <meta name="layout" content="base"/>
    <title>Unauthorized</title>

</head>
<body>

<div class="pageTop">
    <span class="welcomeMessage error">Unauthorized</span>
</div>
<div class="pageBody" id="execUnauthorized">

    <div id="error" class="alert alert-dismissable alert-danger">
        <button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>
        <p>test.user is not authorized to: Read Job 1d425f58-524f-497a-b8e8-e39f8c59a01d</p>
    </div>


</div>
</body>
</html>

This also occurs if they click to view a job definition that they are only allowed to run (but not view), e.g. when creating job snippets in a hidden group/folder to be re-used / called from authorized folders.
@ahonor ahonor added the bug label Mar 11, 2014
@ahonor ahonor added this to the 2.0.2 milestone Mar 11, 2014
@gschueler
Copy link
Member

Hi, what kind of improvement do you think should be done?

@ahonor
Copy link
Contributor

ahonor commented Mar 11, 2014

Should have similar style as other pages in the app. Could have a link back to the project page (or last page visited?)

@mumblez
Copy link
Author

mumblez commented Mar 12, 2014

Thanks Alex, just as you said!
Personally it's no big deal but the end user was complaining it looks unprofessional, short of kicking their teeth out I said I'll see what I can do!

gschueler added a commit that referenced this issue Mar 12, 2014
@gschueler
Merge branch 'fix-error-messages' into development #675
0342563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
3 participants
@gschueler @ahonor @mumblez