This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
[Feat] Docker compose isolation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do agree with this point. The file should have a different name |
WilliamConnatser
approved these changes
Jul 3, 2022
pwltr
suggested changes
Jul 3, 2022
pwltr
approved these changes
Jul 10, 2022
|
@pwltr Fixed |
pwltr
suggested changes
Jul 13, 2022
|
tACK 66d32cc |
AaronDewes
added a commit
that referenced
this pull request
Jul 14, 2022
This reverts commit 1b61d52.
AaronDewes
added a commit
that referenced
this pull request
Jul 14, 2022
This reverts commit 1b61d52.
WilliamConnatser
pushed a commit
that referenced
this pull request
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half way from a feat and a fix.
docker compose upalone won't work since that's missing a few vars that are set inscripts/startIt's thus very confusing for newcomers to see the default
docker-compose.ymlfile which also seemingly start but in a broken state.We should also highlight in the readme that people should only start the node via the start script.