Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix values.schema.json - containerSecurityContext is an instance of io.k8s.api.core.v1.SecurityContext #337

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

milesarmstrong
Copy link
Contributor

what

Update the JSON schema to reflect that containerSecurityContext in values.yaml can be an instance of io.k8s.api.core.v1.SecurityContext

why

To allow the full range of Security Context settings, for instance, we use capabilities.

tests

Checked with https://www.jsonschemavalidator.net/

references

N/A

@milesarmstrong milesarmstrong requested a review from a team as a code owner November 16, 2023 11:52
@milesarmstrong milesarmstrong changed the title Change containerSecurityContext to an instance of io.k8s.api.core.v1.SecurityContext Fix values.schema.json - containerSecurityContext is an instance of io.k8s.api.core.v1.SecurityContext Nov 16, 2023
@milesarmstrong milesarmstrong force-pushed the miles/update-json-schema branch from d31e3c3 to 8b494b3 Compare November 16, 2023 15:05
…SecurityContext, otherwise some fields are invalid
@milesarmstrong milesarmstrong force-pushed the miles/update-json-schema branch from 8b494b3 to 968f1ae Compare November 16, 2023 17:15
@jamengual
Copy link
Contributor

@roytev

@roytev
Copy link
Contributor

roytev commented Nov 16, 2023

LGTM @jamengual

@jamengual jamengual merged commit 7b09cc3 into runatlantis:main Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants