Add loadBalancerSourceRanges to schema #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sviatlo Thanks! i missed it can you please also add it to the values so it will be noticed? |
|
@sviatlo can bump the char version to 4.17.2? thanks. |
sviatlo
force-pushed
the
add_lb_sources_to_schema
branch
from
4a236ee to
4d5c60f
Compare
sviatlo
force-pushed
the
add_lb_sources_to_schema
branch
from
4d5c60f to
c4c3565
Compare
|
@roytev should I set it to null or empty array is good enough? |
|
Hi @sviatlo Thanks it looks good! |
roytev
approved these changes
Nov 15, 2023
|
@roytev @jamengual apologies for bugging you, but could someone please approve a CI run? |
jamengual
approved these changes
Nov 15, 2023
|
@sviatlo Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add loadBalancerSourceRanges to schema
why
The loadBalancerSourceRanges is an existing param in the chart, but passing it to the chart after the schema was added results in
- service: Additional property loadBalancerSourceRanges is not allowederror.tests
Applied with passing the value and without passing the value.