Move vcs host type (github or gitlab) into models package
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable using the VCS type in other packages and avoid circular dependencies. It also makes sense that this is part of the Repo model.
lkysow
commented
Mar 27, 2018
| // Hostname of the VCS provider this repo is hosted on. | ||
| Hostname string | ||
| // VCSHost is where this repo is hosted. | ||
| VCSHost VCSHost |
There was a problem hiding this comment.
Replaced the hostname with the VCSHost model which includes the hostname and the vcs host type.
msarvar
pushed a commit
that referenced
this pull request
Aug 20, 2021
jamengual
pushed a commit
that referenced
this pull request
Nov 23, 2022
meringu
pushed a commit
to meringu/atlantis
that referenced
this pull request
May 29, 2023
Add Getting Started instructions. Rename gh-password to gh-token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VCSHostmodelVCSHosta field onRepoThis will enable use of the VCS type in the locking package but more importantly it makes sense that Atlantis knows where a repo is actually hosted.
Was also thinking about adding Repo as a field to
PullRequestbut haven't done that yet.