Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If GitHub comments are over max size, split into multiple comments. #360

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 22, 2018

image

Notes:

Adds close and (re)open <details> tag in between the split portions to 
ensure the markup is correct across multiple comments. This isn't the prettiest, but a close result, under the assumption continued-comments are in 99% within a terraform output anyway...
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #360 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #360      +/-   ##
=========================================
- Coverage   70.61%   70.6%   -0.01%     
=========================================
  Files          61      61              
  Lines        3682    3681       -1     
=========================================
- Hits         2600    2599       -1     
  Misses        901     901              
  Partials      181     181
Impacted Files Coverage Δ
server/events/vcs/github_client.go 73.8% <83.33%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762c466...63557b4. Read the comment docs.

@lkysow lkysow merged commit e0708c6 into master Nov 23, 2018
@lkysow lkysow deleted the gh-comment-split branch November 23, 2018 14:28
@rngtng
Copy link
Contributor

rngtng commented Nov 24, 2018

nice, and so simple ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants