-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for s3 persistence to log streaming jobs #2157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some docs for this feature as well?
Going to close this one since there is no response. |
Did anyone ever check this PR's code to see if it actually works? It seems a bit silly to throw away work like this only because it doesn't have documentation. If this code actually works, surely someone can (maybe me) can just look at the code to add documentation. |
If you are a golang developer and wants to bring back this feature and add an interface to allow for other storage backends to be added ( not just s3) I do not think we will have any issues on reviewing the PR. |
Changes
Refactor
log handler
intoreceiver registry
that tracks the active connections for a job andjob store
that deals with storing the logs for the jobs.Add support for persisting log streaming jobs to s3, with the storage backend easily configurable. Other storage backends such as local storage, Google Cloud storage can be easily added by updating the config passed to Atlantis and passing it to the
StorageBackend
.Closes Store plan output in external source such as S3 and post link in the PR comment instead of full output #121