Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for s3 persistence to log streaming jobs #2157

Closed
wants to merge 9 commits into from

Conversation

Aayyush
Copy link
Contributor

@Aayyush Aayyush commented Mar 22, 2022

Changes

@Aayyush Aayyush requested a review from a team as a code owner March 22, 2022 18:28
@jamengual jamengual added feature New functionality/enhancement waiting-on-review Waiting for a review from a maintainer labels May 13, 2022
Copy link
Contributor

@nishkrishnan nishkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some docs for this feature as well?

@jamengual
Copy link
Contributor

Going to close this one since there is no response.
If someone is interested in working on this , please ask to be reopen

@jacob-jameson
Copy link

Did anyone ever check this PR's code to see if it actually works? It seems a bit silly to throw away work like this only because it doesn't have documentation.

If this code actually works, surely someone can (maybe me) can just look at the code to add documentation.

@jamengual
Copy link
Contributor

If you are a golang developer and wants to bring back this feature and add an interface to allow for other storage backends to be added ( not just s3) I do not think we will have any issues on reviewing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants