Kubernetes Manifests #132
Closed
Kubernetes Manifests #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make sense to have this unless it is implemented in Atlantis
Since the manifests need to be edited before they're applied to the cluster I thought it best to list them in the README rather than as files so it's more obvious that you can't just kubectl apply them. I also removed the dns-ssl manifest because it was using tazjin/kubernetes-letsencrypt which is no longer maintained and because there are so many ways to do SSL and routing within Kubernetes that I don't have a specific recommendation.
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 63.82% 63.78% -0.04%
==========================================
Files 40 40
Lines 1957 1955 -2
==========================================
- Hits 1249 1247 -2
Misses 644 644
Partials 64 64
Continue to review full report at Codecov.
|
|
Closing in favor of rebased #133 |
jamengual
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Do not raise error when SQ status doesn't have tags defined * comment update
meringu
pushed a commit
to meringu/atlantis
that referenced
this pull request
May 29, 2023
…ine Fixes runatlantis#121 (runatlantis#132) * plan and apply terraform commands error outputs printed after a new line * Update terraform_client.go * returning error outputs as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved manifests from #99 into README to make it clearer that you can't just
kubectlapply those files but that they need to be edited first.I also removed the dns-ssl manifest because it was using
tazjin/kubernetes-letsencrypt which is no longer maintained and because
there are so many ways to do SSL and routing within Kubernetes that I
don't have a specific recommendation.
Fixes #97