Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Migration #17545

Merged
merged 25 commits into from
Jan 20, 2025
Merged

API Migration #17545

merged 25 commits into from
Jan 20, 2025

Conversation

david-oplatka
Copy link
Contributor

Description

We have switched all of the backend implementation for the Vectara Managed Index from using Vectara's API v1 to API v2. This adds new functionalities, such as allowing new parameters to be specified when indexing documents into Vectara Managed Index or when making queries to one or multiple corpora. This also changes the credentials required to set up the index and connect to the Vectara API.

However, this also has breaking changes with the current implementation. These have all been documented in a new Changelog.md file for Vectara Managed Index. Additionally, all README, documentation, and example notebooks have been updated to reflect the new implementation and demonstrate how to appropriately use this updated version.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I added new tests for existing and new functions to the test files for Vectara Managed Index and Vectara Query Tool and all ran successfully.

  • I added new unit tests to cover this change

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 18, 2025
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Huge change -- thanks for tackling this

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 20, 2025
@logan-markewich logan-markewich merged commit 6f3a661 into run-llama:main Jan 20, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants