-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Migration #17545
Merged
Merged
API Migration #17545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
the
size:XXL
This PR changes 1000+ lines, ignoring generated files.
label
Jan 18, 2025
logan-markewich
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Huge change -- thanks for tackling this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have switched all of the backend implementation for the Vectara Managed Index from using Vectara's API v1 to API v2. This adds new functionalities, such as allowing new parameters to be specified when indexing documents into Vectara Managed Index or when making queries to one or multiple corpora. This also changes the credentials required to set up the index and connect to the Vectara API.
However, this also has breaking changes with the current implementation. These have all been documented in a new
Changelog.md
file for Vectara Managed Index. Additionally, all README, documentation, and example notebooks have been updated to reflect the new implementation and demonstrate how to appropriately use this updated version.Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
I added new tests for existing and new functions to the test files for Vectara Managed Index and Vectara Query Tool and all ran successfully.
Suggested Checklist:
make format; make lint
to appease the lint gods