[Issue #17219] MilvusVectorStore Parse "milvus_search_config" out of "vector_store_kwargs"

[mdavidii]

Description

Currently, the MilvusVectorStore saves "search_config" used by ALL queries during 'init' and we cannot change it at query runtime. This change allows us to override this default init configuration for uses where we need a different search criteria, like in "range queries". We already have a **kwargs parameter in the "query" function parameters we use to pass milvus specific configuration like the "milvus_scalar_filters", and we could use this to pass in a "milvus_search_config".

Fixes # (issue)
17209

Type of Change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

• I believe this change is already covered by existing unit tests

Suggested Checklist:

• I have performed a self-review of my own code
• My changes generate no new warnings
• New and existing unit tests pass locally with my changes

[masci]

PR makes sense to me, one question: should we go with search_config instead of milvus_search_config for the parameter name? This way it might be more obvious that we're overriding the value of self.search_config at query time.

[masci]

You can do search_params=kwargs.get("milvus_search_config", self.search_config)

[mdavidii]

I haven't looked at other vector db's and how they might handle (or whether they even support) these search parameters Since this was an adjustment only for the MilvusVectorStore I figured it would be in line with the "milvus_scalar_filters" "vector_store_kwargs" key to differentiate it as specifically Milvus.

[mdavidii]

kwargs.get("milvus_search_config", self.search_config)

You are right. I changed it to this to follow the pattern used in the rest of the class.