refact: Refactor Document to be natively multimodal
#17204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
| @@ -300,6 +301,7 @@ class BaseNode(BaseComponent): | |||
| metadata_separator: str = Field( | |||
| default="\n", | |||
| description="Separator between metadata fields when converting to string.", | |||
| alias="metadata_seperator", | |||
| @@ -537,18 +539,25 @@ def hash(self) -> str: | |||
|
|
|||
|
|
|||
| class Node(BaseNode): | |||
| text: MediaResource | None = Field( | |||
| text_resource: MediaResource | None = Field( | |||
There was a problem hiding this comment.
Will this have an impact on the current openai multimodal stuff we had working?
There was a problem hiding this comment.
I think it won't, even if the logic is almost duplicated (and we might want to refactor it later), that depends on ChatMessage and not Node.
masci
force-pushed
the
massi/document-v2
branch
from
ec10315 to
bc4ac96
Compare
logan-markewich
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentderive fromNodeand inherit its multimodal capabilities.Part of #15950
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.