Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for 3.8 #16973

Merged
merged 3 commits into from
Nov 17, 2024
Merged

chore: drop support for 3.8 #16973

merged 3 commits into from
Nov 17, 2024

Conversation

masci
Copy link
Member

@masci masci commented Nov 15, 2024

Description

Python 3.8 was EOL'ed last October and won't receive further upgrades. We already updated our CI and made 3.9 the new base reference, and this change reflects that at the package level.

Also with this PR:

  • Updated the lockfiles
  • Fixed a poetry install problem with numpy<2
  • Added eval-type-backport as dependency for 3.9, so we can use from __future__ import annotations alongside Pydantic 2 and start modernizing our codebase

Related to #16962 this will make things easier there.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@logan-markewich
Copy link
Collaborator

hmmm can you try running poetry lock again?

@logan-markewich
Copy link
Collaborator

with this change, we could also set numpy = "*" in core if we wanted to

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 15, 2024
@logan-markewich logan-markewich merged commit aa1f577 into main Nov 17, 2024
11 checks passed
@logan-markewich logan-markewich deleted the massi/3.9 branch November 17, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants