Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeshift Integration docs related fixes #16969

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

sohanpsai
Copy link
Contributor

Description

I had added Pipeshift's API integration to consume LLMs with the perks of llama_index a while back. The example notebooks had some issues so this PR mostly fixes them. This PR doesn't change any functionality.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 15, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@logan-markewich logan-markewich merged commit 018eaca into run-llama:main Nov 15, 2024
10 of 11 checks passed
@sohanpsai
Copy link
Contributor Author

Hi @logan-markewich, need some help with examples section of LLMs for pipeshift integration. It seems like the notebook hasn't restarted properly. Could you just check if that's the issue or if I missed out on something?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants