Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix GraphRAG notebook V2 #16913

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

dexters1
Copy link
Contributor

@dexters1 dexters1 commented Nov 11, 2024

Description

Simplified regex for getting entities, removed expectation of the following characters "(", ")", "{", "}"

These characters are no longer a part of the node.text this is why the regex wasn't returning anything. With these changes the GraphRAG works. Why these characters are no longer a part of the node.text I don't know, if these characters should be a part of the text of the node this will not resolve the issue and make it worse.

Fixes #15173

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Simplified regex for getting entities, removed expectation of the following characters "(", ")", "{", "}"

These characters are no longer a part of the node.text this is why the regex wasn't returning anything. With these changes the GraphRAG works.
Why these characters are no longer a part of the node.text I don't know, if these characters should be a part of the text of the node this will not resolve the issue.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 11, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 11, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) November 11, 2024 22:54
@logan-markewich logan-markewich merged commit 9114604 into run-llama:main Nov 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: Issues with GraphRAG Implementation with LlamaIndex - V2 Tutorial
2 participants