-
Notifications
You must be signed in to change notification settings - Fork 736
feat: allow use of self-signed cert for MinIO server with MinioReader #935
feat: allow use of self-signed cert for MinIO server with MinioReader #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! Thankyou for the contribution @ferdinandosimonetti.
Linting is missing in here if you you could fix that up we are good for merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one comment
llama_hub/minio/minio-client/base.py
Outdated
@@ -12,6 +12,7 @@ | |||
from llama_index.readers.base import BaseReader | |||
from llama_index.readers.schema.base import Document | |||
|
|||
import urllib3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this import inside load_data
method. We follow importing external libraries inside the class to avoid any build failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Try running |
Here we are...
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Finally you conquered the linting god @ferdinandosimonetti 😆 Thank you for the quick response on the PR |
Description
I've added cert_check as an option for MinioReader to avoid problems when the remote MinIO server has TLS enabled, but with a self-signed or untrusted certificate.
How can I run my modified version of MinioReader locally, to perform some test?
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods