Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Example #10

Closed
wants to merge 1 commit into from
Closed

Automate Example #10

wants to merge 1 commit into from

Conversation

tamb
Copy link
Contributor

@tamb tamb commented Aug 24, 2019

npm start now:

  1. runs npm run build
  2. copies the pill.js files over to the example
  3. references pill externally in head

This automates the example and testing

@rumkin rumkin assigned rumkin and unassigned rumkin Aug 25, 2019
@rumkin rumkin self-requested a review August 25, 2019 10:09
"rollup": "^1.7.4",
"serve": "^10.1.2"
},
"scripts": {
"start": "serve -l 8080 -n example",
"start": "npm run build && node copy-files.js && serve -l 8080 -n example",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should use build:iife to avoid redundant, in case of example build, commonjs building and minification.

@rumkin rumkin mentioned this pull request Sep 1, 2019
@rumkin
Copy link
Owner

rumkin commented Sep 2, 2019

@tamb There are some fixes required for this PR. Reminding if you haven't seen my comments yet.

@tamb tamb closed this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants