You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
run_wasm_cli_with_css() should return Result<(), Error>.
When the CLI args cannot be parsed, or one of the required arguments are not passed, it must return an error. Without an error, the bin cannot return an error code to the system. And without a useful exit code indicating errors, using cargo-run-wasm in bash scripts and CI will not properly report failures.
We hit this issue over in parasyte/pixels#406, where a bug in CI went undetected since cargo-run-wasm was introduced two years ago.
Additionally, an error should be returned when the build fails. For obvious reasons.
The text was updated successfully, but these errors were encountered:
Adds CI steps to check and lint the example. And fixes build failures introduced by updating `winit` and `wgpu` in #391.
`run-wasm` still won't fail out the WASM CI job when there are build errors. That is tracked upstream in rukai/cargo-run-wasm#49Closes#406
run_wasm_cli_with_css()
should returnResult<(), Error>
.When the CLI args cannot be parsed, or one of the required arguments are not passed, it must return an error. Without an error, the bin cannot return an error code to the system. And without a useful exit code indicating errors, using
cargo-run-wasm
in bash scripts and CI will not properly report failures.We hit this issue over in parasyte/pixels#406, where a bug in CI went undetected since
cargo-run-wasm
was introduced two years ago.Additionally, an error should be returned when the build fails. For obvious reasons.
The text was updated successfully, but these errors were encountered: