Added 'query_cache' option for search #886
Conversation
| @@ -22,6 +22,7 @@ class Search | |||
| const OPTION_SIZE = 'size'; | |||
| const OPTION_SCROLL = 'scroll'; | |||
| const OPTION_SCROLL_ID = 'scroll_id'; | |||
| const OPTION_QUERY_CACHE = 'query_cache'; | |||
There was a problem hiding this comment.
To make this work, it must also be added to _validateOptions: https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Search.php#L273 Best would be to add a small tests to make sure it works as expected.
There was a problem hiding this comment.
Thanks, fixed. I'll have a look how to run the tests but if it takes more time I'm not sure when I can get to that.
There was a problem hiding this comment.
In case you have boot2docker running, it is quite simple:
make run RUN="phpunit -c ./test lib/Elastica/Test/SearchTest.php"
This runs the SearchTest.php file. The first time will take a little bit longer as it must fetch all the docker images.
There was a problem hiding this comment.
Thanks, I've added the test. Btw. the query_cache option will probably work only with search_type=count but that's expected behavior (https://www.elastic.co/guide/en/elasticsearch/reference/1.6/index-modules-shard-query-cache.html#index-modules-shard-query-cache).
Added 'query_cache' option for search
|
Merged, thanks. I would be not surprised if soonish query_cache is also supported for other search_types the way the doc is written. Lets see :-) |
|
@JanJakes Just for my own feedback: Was there any issue in setting up the project to run the tests? |
|
@ruflin It was actually supereasy :) Just running boot2docker and the single make run command exactly like you said. At first I just didn't notice that I need absolutely no setup to run these commands - https://github.com/ruflin/Elastica/blob/master/CONTRIBUTING.md#run-tests. |
|
@JanJakes Thanks for the feedback. No setup (except boot2docker) is the beauty of it ;-) You mean I should emphasize that there is REALLY no other setup needed? |
|
@ruflin Yeah, maybe :) I mean it's not a standard (yet) to have repos prepared with Docker bootstrap as simple as this one. |
|
Not yet. Probably the CONTIRUBTING pages needs a tl;dr |
No description provided.