-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-match query do not support match query options #462
Conversation
Agree. Can you open a pull request with this addition? |
Note: I haven't tested it, so there maybe bugs etc... |
Thx for the addition. Before we merge it, we need some tests to make sure it works. Also see pull request guidelines: |
@luiges90 Any updates here? |
Sorry, but I have stopped using PHP because I left the company. Anyone interested may take over my work. Thank you. |
Ok, thx for the update. |
Hello there ! I needed to set the type of a multimatch query and came out using We could also add the types of multimatch as constants, like: const MULTIMATCH_PHRASE = 'phrase'; What do you think ? |
@OwlyCode It is planned to merge this pull request but it still needs some additions (see comments above). I agree that we should introduce the constant. Perhaps you can take over the pull request and add the missing parts so we can merge it? |
It's ok for me, I'll work on it in the coming days. ;-) |
Ok, let me know when you pushed the changes as I somehow don't get notifications for new commits. |
I submitted a new PR as I couldn't push to this one (#569). |
According to elasticsearch documentation, the multi-match query support all other options in match query. However, the
Elastica\Query\MultiMatch
class do not support setting options of match query.I have also directly make a multi-match query request to my local copy of elasticsearch server with match parameters and it seems working
While at the moment we could use
setParam
to directly set the data, it would be nice to have the Multi-match Query class support this, I think.