Add possibility to specify PointInTime on Elastica\Query::setPointInTime() #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePanz
force-pushed
the
add-pit-search-parameter
branch
from
b7e3346 to
406bc04
Compare
ruflin
reviewed
Oct 11, 2021
thePanz
force-pushed
the
add-pit-search-parameter
branch
from
406bc04 to
7181c98
Compare
|
@ruflin tests (functional and unit) added :) |
ruflin
approved these changes
Oct 19, 2021
| /** | ||
| * Implementation of Point-In-Time for the Search request. | ||
| */ | ||
| class PointInTime extends Param |
There was a problem hiding this comment.
I wonder if at one stage we need to find a better place for these classes instead of having all of them at the top level.
There was a problem hiding this comment.
True, but there are more of those "request" models around at the root namespace.
What do you suggest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html#search-after