Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong json encoding for global aggregation #1860

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fix wrong json encoding for global aggregation #1860

merged 1 commit into from
Nov 3, 2020

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Nov 2, 2020

No description provided.

deguif referenced this pull request Nov 2, 2020
@deguif
Remove specific hack for global aggregation (#1827)
e40a6be 
* Remove specific hack for global aggregation

* Fix test
ruflin
ruflin reviewed Nov 2, 2020
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check CI?

@deguif
Copy link
Collaborator Author

deguif commented Nov 2, 2020

@ruflin CI is green.
The red one is the commit referenced.

@ruflin
Copy link
Owner

ruflin commented Nov 3, 2020

@deguif Ups, sorry about that.

@deguif deguif merged commit df961b1 into ruflin:master Nov 3, 2020
@deguif deguif deleted the fix-wrong-json-encoding branch November 3, 2020 08:22
@deguif deguif self-assigned this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@deguif deguif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deguif @ruflin