Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Range::setKeyedResponse() in favor of setKeyed() #1848

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Deprecate Range::setKeyedResponse() in favor of setKeyed() #1848

merged 3 commits into from
Oct 28, 2020

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Oct 27, 2020

setKeyed() is used in:

  • Elastica\Aggregation\Percentiles
  • Elastica\Aggregation\PercentilesBucket

Let's use it there too. Feels more natural.

@deguif deguif force-pushed the deprecate-set-keyed-response branch 2 times, most recently from b1ee291 to 74f69d6 Compare October 27, 2020 17:50
@deguif deguif force-pushed the deprecate-set-keyed-response branch from 74f69d6 to 7587b4a Compare October 27, 2020 18:14
ruflin
ruflin approved these changes Oct 27, 2020
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure to clean all these up before we go with 8.0 ;-)

@deguif deguif merged commit cb72158 into ruflin:master Oct 28, 2020
@deguif deguif deleted the deprecate-set-keyed-response branch October 28, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deguif @ruflin