Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ingest pipeline endpoint classes #1834

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Oct 26, 2020

See previous (old) PR on official elasticsearch library: elastic/elasticsearch-php#968
This is to prepare support for version 8.x

@deguif
Copy link
Collaborator Author

deguif commented Oct 27, 2020

Merging even if failed, as failure is due to a 403 when downloading php-cs-fixer on a job that doesn't need it.

@deguif deguif merged commit 1926753 into ruflin:master Oct 27, 2020
@deguif deguif deleted the use-new-ingest-pipeline-classes branch October 27, 2020 06:36
@ruflin
Copy link
Owner

ruflin commented Oct 27, 2020

@deguif Please do not merge on red CI even if you assume it is not related. We rather rerun CI. Happy to give you access to do that.

@deguif
Copy link
Collaborator Author

deguif commented Oct 27, 2020

@ruflin sorry about that, I will not merge next time when it's red.
Instead I will trigger another build by amending last commit.

@ruflin
Copy link
Owner

ruflin commented Oct 27, 2020

@deguif An other option is to get you trigger permissions on the Travis build so you can retrigger it in the UI. Can you check if you already have access there because you are a contributor? If not, let me figure out how I can give you access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants