Allow metadata to be set on AbstractAggregation (#1677) #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticSearch allows metadata to be set on an aggregation that will be returned as-is with the aggregation result. See https://www.elastic.co/guide/en/elasticsearch/reference/6.8/agg-metadata.html Using `setParam` generates invalid query, hence these additions. See #1677
ruflin
reviewed
Oct 21, 2019
| /** | ||
| * @var array|null Metadata belonging to this aggregation | ||
| */ | ||
| protected $_meta; |
There was a problem hiding this comment.
Do we need a separate _meta key here or could we just use the internal setParam?
There was a problem hiding this comment.
After going over the code in AbstractAggregation::toArray() I agree the problem could be solved by using AbstractAggregation::_setRawParam($key, $value).
|
Closing this and opening #1680 instead. Branched from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElasticSearch allows metadata to be set on an aggregation that will be
returned as-is with the aggregation result.
See https://www.elastic.co/guide/en/elasticsearch/reference/6.8/agg-metadata.html
Using
setParamgenerates invalid query, hence these additions. See#1677