Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an aws_credential_provider connection parameter for more flexible credentials strategies #1667

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Oct 4, 2019

Intended to address #1651. This PR updates the AWSAuthV4 transport to support an additional configuration parameter (aws_credential_provider) to allow users to supply a callable credential provider. This would let users customize their provider to include caching, fetch credentials from a non-standard location, etc.

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a changelog entry?

I must confess, I didn't test this one so just trust your change :-)

@jeskew jeskew force-pushed the feature/support-credential-provider-in-awsauth-transport branch from c5f8ea8 to a83a3c6 Compare December 31, 2019 15:00
@jeskew jeskew force-pushed the feature/support-credential-provider-in-awsauth-transport branch from a83a3c6 to 6ebafe2 Compare December 31, 2019 15:16
@jeskew
Copy link
Contributor Author

jeskew commented Dec 31, 2019

@ruflin Sorry for the radio silence on this PR! I added a changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants