add parent_id in QueryBuilder #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p365labs
force-pushed
the
add_querybuilder_parentId
branch
2 times, most recently
from
e02f8e3 to
8cb1058
Compare
p365labs
force-pushed
the
add_querybuilder_parentId
branch
from
8cb1058 to
3862e06
Compare
p365labs
force-pushed
the
add_querybuilder_parentId
branch
from
3862e06 to
219c75a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement parent_id inside QueryBuilder --> #1518
I put tests inside ParentIdTest class, I've thought a lot where to place it.
Maybe could be a better place DSL\QueryTest, in fact the test is a copycat of
the test for ParentId implementing QueryBuilder instead of using object itself.
what do u think @ruflin ?