Added support to parent_id query #1308
Conversation
giovannialbero1992
changed the title
lib/Elastica/Query/ParentId.php
Outdated
| <?php | ||
| namespace Elastica\Query; | ||
|
|
||
| final class ParentId extends AbstractQuery |
There was a problem hiding this comment.
I usually apply final by default to classes that are not specifically designed to be extended.
This avoids breaking an eventual child class when refactoring this class.
If you want i can remove final from this class.
There was a problem hiding this comment.
I would prefer to remove it as we don't have it in any other files and I don't see a reason, why we should prevent someone extendings this class if we wants to (even though it is unlikely to happen).
There was a problem hiding this comment.
Ok, I've removed final
CHANGELOG.md
Outdated
| @@ -13,7 +13,7 @@ All notable changes to this project will be documented in this file based on the | |||
| ### Added | |||
|
|
|||
| - Parameter `filter_path` for response filtering (e.g. `$index->search($query, ['filter_path' => 'hits.hits._source'])`) | |||
|
|
|||
| - Added `\Elastica\Query\ParentId` to avoid join with parent documents [#1287](https://github.com/ruflin/Elastica/issues/1287) | |||
There was a problem hiding this comment.
Could also add here a newline before the next title?
giovannialbero1992
force-pushed
the
master
branch
2 times, most recently
from
0d3f11b to
cfc1d5b
Compare
giovannialbero1992
force-pushed
the
master
branch
2 times, most recently
from
5c1ccc8 to
8643d83
Compare
|
@giovannialbero1992 Seems like you have changelog conflict :-( |
giovannialbero1992
force-pushed
the
master
branch
from
8643d83 to
23f1545
Compare
|
@ruflin Done! ;-) |
|
@giovannialbero1992 Thanks. merged. |
added ParentId Query by reference #1287