Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es test version to 5.2 #1245

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Update es test version to 5.2 #1245

merged 1 commit into from
Apr 13, 2017

Conversation

ruflin
Copy link
Owner

@ruflin ruflin commented Feb 8, 2017

No description provided.

@ruflin ruflin mentioned this pull request Feb 8, 2017
7 tasks
@XWB
Copy link
Contributor

XWB commented Mar 30, 2017

@ruflin Any ETA on the next release? It would be nice to have a release containing 3e02937

@ruflin
Copy link
Owner Author

ruflin commented Mar 30, 2017

No ETA but definitively something I can push forward :-) Put it on my TODO list.

@XWB
Copy link
Contributor

XWB commented Mar 30, 2017

Put it on my TODO list.

Excellent :)

@ruflin ruflin force-pushed the update-to-es520 branch 2 times, most recently from a545519 to 1380d09 Compare April 13, 2017 07:27
* Update elasticsearch-php dependency to 5.2
* Update incompatible test
* Update README page
* Update CHANGELOG
@ruflin ruflin merged commit 8b45039 into master Apr 13, 2017
@ruflin ruflin deleted the update-to-es520 branch April 13, 2017 08:11
@ruflin
Copy link
Owner Author

ruflin commented Apr 21, 2017

@XWB
Copy link
Contributor

XWB commented Apr 21, 2017

Yes, already installed :) Thanks!

@XWB
Copy link
Contributor

XWB commented May 24, 2017

@ruflin

All FOSElasticaBundle resetter tests fail after upgrading Elastica to 5.2, any idea where I should start looking?

@ruflin
Copy link
Owner Author

ruflin commented May 26, 2017

Could you share the CI error you get? What is resetter doing?

@XWB
Copy link
Contributor

XWB commented May 27, 2017

@ruflin

  1. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetAllIndexes
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  2. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndex
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  3. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndexWithDifferentName
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  4. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndexWithDifferentNameAndAlias
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  5. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetType
    Expectation failed for method name is equal to string:request when invoked 3 time(s).
    Method was expected to be called 3 times, actually called 0 times.

  6. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetTypeWithChangedSettings
    Expectation failed for method name is equal to string:request when invoked 3 time(s).
    Method was expected to be called 3 times, actually called 0 times.

@ruflin
Copy link
Owner Author

ruflin commented May 29, 2017

Could this be related to #1277 ?

@XWB
Copy link
Contributor

XWB commented May 31, 2017

I think so, but I have no clue where to start looking.

@ruflin
Copy link
Owner Author

ruflin commented Jun 2, 2017

I think the problem is that you check for request calls but now requestEndpoint is called. TBH this kind of test is quite new to me :-)

@XWB
Copy link
Contributor

XWB commented Jun 7, 2017

Found it, thanks :)

FriendsOfSymfony/FOSElasticaBundle@f434157

mhernik pushed a commit to mhernik/Elastica that referenced this pull request Jul 24, 2017
* Update elasticsearch-php dependency to 5.2
* Update incompatible test
* Update README page
* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants