Allow using IAM Authentication with Amazon ElasticSearch service #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruflin I don't believe the CircleCI failure is related to this pull request; all recent PRs are failing with a similar message. |
|
@jeskew The circleci issue definitively isn't related. I just tried out Circle-CI and forgot to disable it. Will have a look at the PR later. |
|
LGTM. I like that it is completely decoupled and an optional dependency. Could you update the CHANGELOG.md and squash the commits afterwards if possible? |
|
@ruflin The changelog has been updated and the commits squashed. |
ruflin
added a commit
that referenced
this pull request
Mar 18, 2016
Allow using IAM Authentication with Amazon ElasticSearch service
|
@jeskew Merged. Thanks a lot. |
Closed
| @@ -16,12 +16,14 @@ | |||
| "psr/log": "~1.0" | |||
| }, | |||
| "require-dev": { | |||
| "guzzlehttp/guzzle": "~6.0" | |||
| "guzzlehttp/guzzle": "~6.0", | |||
| "aws/aws-sdk-php": "~3.0" | |||
There was a problem hiding this comment.
impossible to install this version using php 5.4, but above requirements say that it's >=5.4
There was a problem hiding this comment.
If you install without require-dev, php5.4 works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional dependency on the AWS SDK for PHP and adds support for AWS Auth signing of requests sent to the Amazon ElasticSearch Service.
This would resolve #948.