Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Index::setSettings broken? #1295

Closed
nickygerritsen opened this issue Apr 30, 2017 · 3 comments · Fixed by #1296
Closed

[5.2] Index::setSettings broken? #1295

nickygerritsen opened this issue Apr 30, 2017 · 3 comments · Fixed by #1296

Comments

@nickygerritsen
Copy link
Contributor

It seems that in 5.2+ setSettings on an Index is broken. It tries to set the settings on the whole cluster instead of only the index.

In 5.1 this still works.

If I take a short look at the code it seems Elasticsearch\Endpoints\Cluster\Settings\Put is the wrong class and we should use Elasticsearch\Endpoints\Indices\Settings\Put instead?

@ruflin
Copy link
Owner

ruflin commented May 3, 2017

@nickygerritsen Thanks for reporting. I think you are right. Could you open a PR with a bug fix?

@ewgRa FYI

@ewgRa
Copy link
Contributor

ewgRa commented May 3, 2017

@nickygerritsen I think you are right. Can you make pull request? It is trivial, and would be nice to cover this case by test.

@nickygerritsen
Copy link
Contributor Author

On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants