adding some tests for percolate exisiting docs with paramters

ruflin · Mar 16, 2014 · 86ca940 · 86ca940
1 parent 6ee78f1
commit 86ca940
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 3 deletions.
diff --git a/changes.txt b/changes.txt
@@ -1,5 +1,8 @@
 CHANGES
 
+2014-03-15
+- percolate existing documents and add percolate options (#570)
+
 2014-03-11
 - Fixed request body reuse in http transport #567
 

diff --git a/lib/Elastica/Percolator.php b/lib/Elastica/Percolator.php
@@ -75,7 +75,7 @@ public function matchDoc(Document $doc, $query = null, $type = 'type', $params =
         $path = $this->_index->getName() . '/' . $type . '/_percolate';
         $data = array('doc' => $doc->getData());
 
-        return $this->percolate($path, $query, $data, $params);
+        return $this->_percolate($path, $query, $data, $params);
     }
 
     /**
@@ -93,7 +93,7 @@ public function matchExistingDoc($id, $type, $query = null, $params = array())
         $id = urlencode($id);
         $path = $this->_index->getName() . '/' . $type . '/'. $id . '/_percolate';
 
-        return $this->percolate($path, $query, array(), $params);
+        return $this->_percolate($path, $query, array(), $params);
     }
 
     /**
@@ -103,7 +103,7 @@ public function matchExistingDoc($id, $type, $query = null, $params = array())
      * @param  array  $params
      * @return array
      */
-    protected function percolate($path, $query, $data = array(), $params = array())
+    protected function _percolate($path, $query, $data = array(), $params = array())
     {
         // Add query to filter the percolator queries which are executed.
         if ($query) {

diff --git a/test/lib/Elastica/Test/PercolatorTest.php b/test/lib/Elastica/Test/PercolatorTest.php
@@ -155,4 +155,70 @@ public function testRegisterAndUnregisterPercolator()
 
         $index->delete();
     }
+
+    protected function _getDefaultPercolator($percolatorName = 'existingDoc')
+    {
+        $index = $this->_createIndex();
+        $percolator = new Percolator($index);
+
+        $query = new Term(array('name' => 'foobar'));
+        $percolator->registerQuery($percolatorName, $query);
+        return $percolator;
+    }
+
+    protected function _addDefaultDocuments($index, $type='testing')
+    {
+        $type = $index->getType('testing');
+        $doc1 = new Document(1, array('name' => 'foobar'));
+        $doc2 = new Document(2, array('name' => 'barbaz'));
+        $type->addDocument($doc1);
+        $type->addDocument($doc2);
+        $index->refresh();
+        return $type;
+    }
+
+    public function testPercolateExistingDocWithoutAnyParameter()
+    {
+        $percolator = $this->_getDefaultPercolator();
+        $index      = $percolator->getIndex();
+        $type       = $this->_addDefaultDocuments($index);
+
+        $matches = $percolator->matchExistingDoc(1, $type->getName());
+
+        $this->assertCount(1, $matches);
+        $this->assertEquals('existingDoc', $matches[0]['_id']);
+        $index->delete();
+    }
+
+    public function testPercolateExistingDocWithPercolateFormatIds()
+    {
+        $percolator = $this->_getDefaultPercolator();
+        $index      = $percolator->getIndex();
+        $type       = $this->_addDefaultDocuments($index);
+
+        $parameter = array('percolate_format' => 'ids');
+        $matches   = $percolator->matchExistingDoc(1, $type->getName(), null, $parameter);
+
+        $this->assertCount(1, $matches);
+        $this->assertEquals('existingDoc', $matches[0]);
+        $index->delete();
+    }
+
+    public function testPercolateExistingDocWithIdThatShouldBeUrlEncoded()
+    {
+        $percolator = $this->_getDefaultPercolator();
+        $index      = $percolator->getIndex();
+        $type       = $this->_addDefaultDocuments($index);
+
+        // id with whitespace, should be urlencoded
+        $id = "foo bar 1";
+
+        $type->addDocument(new Document($id, array('name' => 'foobar')));
+        $index->refresh();
+
+        $matches = $percolator->matchExistingDoc($id, $type->getName());
+
+        $this->assertCount(1, $matches);
+        $index->delete();
+    }
 }