Skip to content

Commit

Permalink
Remove Elasticsearch old version checks in tests (#2041)
Browse files Browse the repository at this point in the history
* Remove old Elasticsearch version check in tests

* Add changelog
  • Loading branch information
deguif authored Dec 7, 2021
1 parent bb26470 commit 6761bdd
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 10 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed
* Removed remaining `_type` field usages [#2017](https://github.com/ruflin/Elastica/pull/2017)
* Removed `Elastica\Bulk::$_type` dead property [#2034](https://github.com/ruflin/Elastica/pull/2034)
* Removed Elasticsearch old version checks in tests [#2041](https://github.com/ruflin/Elastica/pull/2041)
### Fixed
* Fixed type-hint for `Elastica\Search::setOptionsAndQuery()` [#2009](https://github.com/ruflin/Elastica/pull/2009)
* Fixed terms query params resolution [#2032](https://github.com/ruflin/Elastica/pull/2032)
Expand Down
2 changes: 0 additions & 2 deletions tests/Aggregation/DateHistogramTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ public function testSetOffset(): void
*/
public function testSetOffsetWorks(): void
{
$this->_checkVersion('1.5');

$agg = new DateHistogram('hist', 'created', '1m');
$agg->setOffset('+40s');

Expand Down
2 changes: 0 additions & 2 deletions tests/Aggregation/WeightedAvgTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ class WeightedAvgTest extends BaseAggregationTest
*/
public function testWeightedAvgAggregation(): void
{
$this->_checkVersion('6.4');

$agg = new WeightedAvg('weighted');
$agg->setValue('price');
$weightWhenMissing = 2;
Expand Down
4 changes: 0 additions & 4 deletions tests/Query/FunctionScoreTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,6 @@ public function testScriptScore(): void
*/
public function testSetMinScore(): void
{
$this->_checkVersion('1.5');

$expected = [
'function_score' => [
'min_score' => 0.8,
Expand Down Expand Up @@ -525,8 +523,6 @@ public function testSetMinScore(): void
*/
public function testFieldValueFactor(): void
{
$this->_checkVersion('1.6');

$expected = [
'function_score' => [
'functions' => [
Expand Down
2 changes: 0 additions & 2 deletions tests/Query/SimpleQueryStringTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ public function testSetMinimumShouldMatch(): void
*/
public function testSetMinimumShouldMatchWorks(): void
{
$this->_checkVersion('1.5');

$index = $this->_createIndex();

$index->addDocuments([
Expand Down

0 comments on commit 6761bdd

Please sign in to comment.