Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Fixes several text edit font and bullet issues (parts of #1167) #4979

Merged
merged 1 commit into from
Aug 3, 2021
Merged

core: Fixes several text edit font and bullet issues (parts of #1167) #4979

merged 1 commit into from
Aug 3, 2021

Conversation

hatal175
Copy link
Contributor

@hatal175 hatal175 commented Aug 2, 2021

  • fixes bullet and margin interaction
  • fixes line heading - max font size is reset every new line
  • fixes adding a bullet for every line break instead of every explicit one

Still has an issue where an additional bullet is added. Will explain more in original issue.

Herschel
Herschel approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@Herschel Herschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and welcome!

@Herschel Herschel merged commit 6762675 into ruffle-rs:master Aug 3, 2021
@danielhjacobs
Copy link
Contributor

It's better than prior to this commit, but there are still more bullet issues other than what you already mentioned in #1167. See #1167 (comment).

@hatal175 hatal175 deleted the bulletsize branch September 1, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Herschel Herschel Herschel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hatal175 @danielhjacobs @Herschel