Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Handle font fallback for more known monospace fonts #19138

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Jan 5, 2025

This is based on the behavior of Flash: when no device font is available, Flash falls back to a monospace font for the following fonts:

  • Consolas
  • Courier
  • Courier New
  • NSimSun

Checked all default fonts of Windows and MacOS.

@kjarosh kjarosh added text Issues relating to text rendering/input A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) labels Jan 5, 2025
@kjarosh kjarosh enabled auto-merge (rebase) January 6, 2025 13:50
This is based on the behavior of Flash: when no device font is available,
Flash falls back to a monospace font for the following fonts:

* Consolas
* Courier
* Courier New
* NSimSun
@kjarosh kjarosh force-pushed the monospace-fallback branch from e38aaad to fcaa573 Compare January 6, 2025 13:50
@kjarosh kjarosh merged commit 80a8e03 into ruffle-rs:master Jan 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) text Issues relating to text rendering/input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants