desktop: Improve backend selection #15647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
force-pushed
the
backend_selection
branch
from
daffbd6 to
8bb0aea
Compare
adrian17
reviewed
Mar 21, 2024
adrian17
reviewed
Mar 21, 2024
| wgpu::Backends::empty() | ||
| } else { | ||
| backend | ||
| } | ||
| } | ||
|
|
||
| fn find_available_graphics_backends() -> wgpu::Backends { |
There was a problem hiding this comment.
earlier you mentioned that
I think we can remove that code now, wgpu added an api to show which backends are (roughly) available
Just wanna make sure whether that was checked :D
There was a problem hiding this comment.
Yeah, turns out that's unreleased still :(
wgpu::Instance::enabled_backend_features() in the next major wgpu update
adrian17
approved these changes
Mar 21, 2024
Dinnerbone
force-pushed
the
backend_selection
branch
from
8bb0aea to
f621be0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now try every single backend one-by-one to work around gfx-rs/wgpu#2384 & gfx-rs/wgpu#5324