Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for hashed cart token as anonymousid #4046

Conversation

yashasvibajpai
Copy link
Member

What are the changes introduced in this PR?

if anonymousId is not present in note_attributes or redis, generate a new anonymousId. The anonymousId will be generated by hashing the cart_token using uuidv5, also adding this anonymousId inside traits object in cart_token_hash key

What is the related Linear task?

Resolves INT-3214

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

koladilip and others added 2 commits February 3, 2025 16:28
* refactor: add more tests for middleware and router utils

* refactor: add more tests for adobe analytics and network utils
@yashasvibajpai yashasvibajpai self-assigned this Feb 4, 2025
@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners February 4, 2025 17:26
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (hotfix/6th.Feb.2025@16b927a). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             hotfix/6th.Feb.2025    #4046   +/-   ##
======================================================
  Coverage                       ?   91.00%           
======================================================
  Files                          ?      629           
  Lines                          ?    32834           
  Branches                       ?     7790           
======================================================
  Hits                           ?    29881           
  Misses                         ?     2702           
  Partials                       ?      251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link
Collaborator

@krishna2020 krishna2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's duplicate code

@yashasvibajpai yashasvibajpai changed the title chore: add support for hashed cart token as anonymousid feat: add support for hashed cart token as anonymousid Feb 5, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@yashasvibajpai yashasvibajpai requested review from a team as code owners February 5, 2025 08:59
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

koladilip
koladilip previously approved these changes Feb 5, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this shopify_pixel_cart_token_not_found_server_side be removed now ?

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@yashasvibajpai yashasvibajpai changed the base branch from develop to hotfix/6th.Feb.2025 February 6, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants