chore: use internal build-scan-push for security scans #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allure Test reports for this run are available at: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4044 +/- ##
========================================
Coverage 91.00% 91.00%
========================================
Files 629 629
Lines 32824 32827 +3
Branches 7788 7788
========================================
+ Hits 29871 29874 +3
Misses 2734 2734
Partials 219 219 ☔ View full report in Codecov by Sentry. |
| @@ -36,6 +36,10 @@ on: | |||
| DOCKERHUB_PROD_TOKEN: | |||
| required: true | |||
|
|
|||
| permissions: | |||
There was a problem hiding this comment.
what is the use of these?
yashasvibajpai
approved these changes
Feb 4, 2025
krishna2020
approved these changes
Feb 6, 2025
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
|
|
Allure Test reports for this run are available at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
We are moving to a custom
docker-build-scan-pushworkflow which takes care of scaning the repo for secrets using trufflehog before building the image.What is the related Linear task?
Resolves INT-3167
Please explain the objectives of your changes below
Improving security
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
No
Any new dependencies introduced with this change?
rudderlabs/docker-scan-build-push
Any new generic utility introduced or modified. Please explain the changes.
No
Any technical or performance related pointers to consider with the change?
No
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.