Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend statuscode check to 502 to retry the request #4029

Merged

Conversation

abhimanyubabbar
Copy link
Contributor

What are the changes introduced in this PR?

This PR includes a simple statuscode check extension to include 502 status code from upstream openfaas gateway server to retry the request. Currently, an exception is thrown and the rudder-server doesn't retry causing the transient failure to be sticky and permanent.

This results in dataloss for our customers. This change prevents that.

What is the related Linear task?

Resolves DAT-1900

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (98a54ad) to head (079e623).
Report is 1 commits behind head on hotfix/29012025-ut.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           hotfix/29012025-ut    #4029   +/-   ##
===================================================
  Coverage               90.82%   90.82%           
===================================================
  Files                     627      627           
  Lines                   32692    32692           
  Branches                 7763     7760    -3     
===================================================
  Hits                    29694    29694           
  Misses                   2775     2775           
  Partials                  223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@abhimanyubabbar abhimanyubabbar changed the base branch from develop to hotfix/29012025-ut January 29, 2025 06:53
@ItsSudip ItsSudip merged commit d003676 into hotfix/29012025-ut Jan 29, 2025
28 checks passed
@ItsSudip ItsSudip deleted the fix/dat-1900-add-502-status-handling-faas-fn branch January 29, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants