Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix sonar issues in various components #4017

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

koladilip
Copy link
Contributor

What are the changes introduced in this PR?

Mostly small fixes

What is the related Linear task?

Resolves INT-2990

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@koladilip koladilip requested review from a team and sivashanmukh as code owners January 25, 2025 13:28
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (ee33e5c) to head (7a2793e).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4017      +/-   ##
===========================================
+ Coverage    90.82%   90.99%   +0.16%     
===========================================
  Files          627      628       +1     
  Lines        32693    32778      +85     
  Branches      7765     7777      +12     
===========================================
+ Hits         29695    29827     +132     
+ Misses        2775     2732      -43     
+ Partials       223      219       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

utsabc
utsabc previously approved these changes Jan 27, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

vinayteki95
vinayteki95 previously approved these changes Feb 5, 2025
utsabc
utsabc previously approved these changes Feb 5, 2025
@koladilip koladilip dismissed stale reviews from utsabc and vinayteki95 via 087435a February 5, 2025 05:23
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

vinayteki95
vinayteki95 previously approved these changes Feb 5, 2025
it wasn't behaving very well with typescript so removed.
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@koladilip koladilip merged commit 91ef21d into develop Feb 5, 2025
27 checks passed
@koladilip koladilip deleted the fix/sonar-issues-dt-2 branch February 5, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants